chore!: remove leftovers from when virtuals were symlinks #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/virtual-symlink
branch
from
bd1ff69 to
7b91207
Compare
|
Can |
arcanis
reviewed
Mar 1, 2021
Removing it would require to hardcode the path, which we try to avoid in general. Modifying this setting doesn't really make sense, but this way the exact path is stored along with all others, and can be easily accessed by any plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
There are leftovers in the codebase from the time when virtuals (peer dependencies) were symlinks
Closes #2003
How did you fix it?
Removed them
Checklist